Resolve missing nodetoolkit #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scroix
commented
Dec 8, 2022
| @@ -568,7 +560,6 @@ private void applyConfig0(NodeConfig config) throws Exception { | |||
|
|
|||
| trackFunction("(instance creation)"); | |||
|
|
|||
| // _python = new PythonInterpreter(globals, pySystemState); | |||
There was a problem hiding this comment.
It's strange this object gets built up with the correct working directories but never passed to the interpreter.
|
You can achieve the same result from within the Jython interpreter by doing this after the node launches. import sys
sys.path.append(_node.getRoot().getAbsolutePath())
sys.path.append(str(_node.getRoot().getAbsolutePath()) + '\\.nodel')
from nodetoolkit import *If you wanted to do it from Java whilst instantiating the interpreter object, just before the script launches, this works as well. _python.exec("import sys");
_python.exec("sys.path.append(_node.getRoot().getAbsolutePath())");
_python.exec("sys.path.append(str(_node.getRoot().getAbsolutePath()) + '\\.nodel')");
_python.exec("from nodetoolkit import *"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the public PR (museumsvictoria#250 (comment)) the nodetoolkit which provides all the action/event and utility functions wasn't available in the Jython interpreter.
It seems this was because the toolkit itself
node_root/.nodel/nodetoolkit.pywas missing from sys.path. There was an attempt to add it to the pySystemState but for some reason this was commented out in the original code.I also took the opportunity to update this endeavour to Jython 2.7.3 which came out recently.